perf: Optimize array traversal for empty memory-graph documents#770
Merged
MaheshtheDev merged 1 commit intosupermemoryai:mainfrom Mar 8, 2026
Merged
perf: Optimize array traversal for empty memory-graph documents#770MaheshtheDev merged 1 commit intosupermemoryai:mainfrom
MaheshtheDev merged 1 commit intosupermemoryai:mainfrom
Conversation
Dhravya
approved these changes
Mar 6, 2026
Contributor
Author
|
hi @MaheshtheDev can we merge this now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Replaced
nodes.filter((n) => n.type === "document").length === 0with!nodes.some((n) => n.type === "document")across all memory-graph.tsx components (apps/web/,packages/ui/, andpackages/memory-graph/).Why:
The previous approach (
filter().length === 0) was highly inefficient because it would:.lengthof the newly created array.Using
!nodes.some(...)stops the iteration immediately once a match is found and completely avoids the array allocation, resulting in better performance. I tested it on a benchmark by comparing both approaches using an array of 1,000,000 nodes running 100 iterations.filter) 700mssome) 0.2ms (~3684x improvement)filter): 903.60mssome): 0.46ms (~1964x improvement)@Dhravya @MaheshtheDev please have a look